Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually build website and upload artifacts #3559

Merged
merged 9 commits into from
Jun 17, 2023
Merged

Conversation

AaronCrawfis
Copy link
Collaborator

@AaronCrawfis AaronCrawfis commented Jun 16, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR:

  • Manually builds the hugo site and deploys to the Azure SWA instead of using SWA's Onyx builder
  • Uploads the assets for later review

Why?

  • Future PRs can leverage the uploaded package for indexing or other processing
  • Errors can be better isolated to an individual step
  • Can add caching in a future PR

This PR lays the groundwork for a couple other PRs I have coming in

Issue reference

N/A

@AaronCrawfis AaronCrawfis requested review from a team as code owners June 16, 2023 21:53
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-bay-0e9e0e81e-3559.westus2.azurestaticapps.net

hhunter-ms and others added 3 commits June 16, 2023 15:13
Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

Signed-off-by: Aaron Crawfis <[email protected]>
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-bay-0e9e0e81e-3559.westus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-bay-0e9e0e81e-3559.westus2.azurestaticapps.net

@AaronCrawfis AaronCrawfis mentioned this pull request Jun 16, 2023
7 tasks
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-bay-0e9e0e81e-3559.westus2.azurestaticapps.net

@AaronCrawfis AaronCrawfis changed the title Split docs workflow into two steps Manually build website and upload artifacts Jun 17, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-bay-0e9e0e81e-3559.westus2.azurestaticapps.net

@msfussell
Copy link
Member

@AaronCrawfis - Is this good to merge?

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://proud-bay-0e9e0e81e-3559.westus2.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-05112ff1e-3559.westus2.1.azurestaticapps.net

@msfussell msfussell merged commit b975970 into v1.11 Jun 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants